Re: [GSOC PATCH v2 0/2] mailmap: reduce global state

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 20, 2026, 16:16 UTC
Message-ID: <xmqqtsvbz8z2.fsf@gitster.g>
In-Reply-To: <20260220060442.29469-1-bkkaracay@gmail.com>

Burak Kaan Karaçay <bkkaracay@gmail.com> writes:

Show 14 quoted lines

> This patch series aims to reduce the global variable dependency of the
> mailmap subsystem:
>
>   - Patch 1 eliminates the implicit 'the_repository' dependency in the
>     'read_mailmap' and 'read_mailmap_blob' functions by adding a
>     'struct repository' parameter.
>
>   - Patch 2 removes the 'git_mailmap_file' and 'git_mailmap_blob' global
>     variables, shifting to on-demand configuration reading via the config
>     set helpers and using local variables.
>     
> Changes in v2:
>   - Forward declare 'struct repository' in mailmap.h
>   - Fix whitespace problems

Thanks for a quick reroll.  Looking very good.

Will queue.