git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] ci: link failure and leak annotations to the test script

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 30, 2026, 14:37 UTC
Message-ID
<xmqqpkxudcva.fsf@gitster.g>
In-Reply-To
<pull.2419.v3.git.git.1790748583.gitgitgadget@gmail.com>
"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 15 quoted lines
> Link failure and leak annotations in CI to the test script, so both can be
> found from the job summary.
>
> V3 CI Job where failures and leaks are reported:
> https://github.com/git/git/actions/runs/36537917146/job/109306215909?pr=2426
>
> Changes in v3:
>
>  * Fixed bug in the --immediate exit ordering: the --immediate &&
>    --invert-exit-code path called exit 0 before the test's annotation was
>    written, now a single unconditional call covers both exit paths.
>  * github_escape_message_ no longer relies on \r being a portable sed escape
>    sequence (not POSIX-guaranteed and BSD sed implementations can differ),
>    it splices in the literal carriage-return byte via printf instead.
>  * Reverted unrelated test-tool line back to its original form.

With these updates, the patches look good to me. Unless others spot problems I failed to see, let me mark the topic for 'next'.

Thanks.
Previous: Harald NordgrenNext: Phillip Wood
Message 18 of 40 in “ci: point leak-sanitizer failures at the actual test and error”
  1. ci: point leak-sanitizer failures at the actual test and errorHarald Nordgren via GitGitGadget, Sep 25, 2026
  2. Ben KnobleSep 25, 2026
  3. Harald NordgrenSep 25, 2026
  4. Phillip WoodSep 27, 2026
  5. Harald NordgrenSep 27, 2026
  6. 0/2 ci: link failure and leak annotations to the test scriptHarald Nordgren via GitGitGadget, Sep 28, 2026
  7. 2/2 ci: point test failures and fixed known breakages at their file and lineHarald Nordgren via GitGitGadget, Sep 28, 2026
  8. Junio C HamanoSep 28, 2026
  9. 1/2 ci: annotate leaks and stop a leak-sanitizer script at its first failureHarald Nordgren via GitGitGadget, Sep 28, 2026
  10. Junio C HamanoSep 28, 2026
  11. Harald NordgrenSep 29, 2026
  12. 0/2 ci: link failure and leak annotations to the test scriptHarald Nordgren via GitGitGadget, Sep 30, 2026
  13. 1/2 ci: annotate leaks and stop a leak-sanitizer script at its first failureHarald Nordgren via GitGitGadget, Sep 30, 2026
  14. Phillip WoodSep 30, 2026
  15. 2/2 ci: point test failures and fixed known breakages at their file and lineHarald Nordgren via GitGitGadget, Sep 30, 2026
  16. Phillip WoodSep 30, 2026
  17. Harald NordgrenSep 30, 2026
  18. Junio C HamanoSep 30, 2026
  19. Phillip WoodSep 30, 2026
  20. Junio C HamanoSep 30, 2026
  21. 0/2 ci: link failure and leak annotations to the test scriptHarald Nordgren via GitGitGadget, Oct 1, 2026
  22. 1/2 ci: annotate leaks and stop a leak-sanitizer script at its first failureHarald Nordgren via GitGitGadget, Oct 1, 2026
  23. 2/2 ci: point test failures and fixed known breakages at their file and lineHarald Nordgren via GitGitGadget, Oct 1, 2026
  24. Phillip WoodOct 1, 2026
  25. Junio C HamanoOct 1, 2026
  26. Harald NordgrenOct 2, 2026
  27. 0/2 ci: link failure and leak annotations to the test scriptHarald Nordgren via GitGitGadget, Oct 3, 2026
  28. 1/2 ci: annotate leaks and stop a leak-sanitizer script at its first failureHarald Nordgren via GitGitGadget, Oct 3, 2026
  29. 2/2 ci: point test failures and fixed known breakages at their file and lineHarald Nordgren via GitGitGadget, Oct 3, 2026
  30. Phillip WoodOct 3, 2026
  31. Phillip WoodOct 3, 2026
  32. Harald NordgrenOct 4, 2026
  33. Phillip WoodOct 5, 2026
  34. Harald NordgrenOct 5, 2026
  35. Phillip WoodOct 5, 2026
  36. Harald NordgrenOct 4, 2026
  37. 0/2 ci: link failure and leak annotations to the test scriptHarald Nordgren via GitGitGadget, Oct 6, 2026
  38. 1/2 ci: annotate leaks and stop a leak-sanitizer script at its first failureHarald Nordgren via GitGitGadget, Oct 6, 2026
  39. 2/2 ci: point test failures and fixed known breakages at their file and lineHarald Nordgren via GitGitGadget, Oct 6, 2026
  40. Phillip WoodOct 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.