Re: [PATCH] ci: point leak-sanitizer failures at the actual test and error

From: Harald Nordgren <haraldnordgren@gmail.com>
Date: Sep 27, 2026, 19:52 UTC
Message-ID: <CAHwyqnVyDeZV7-ev6+BGeD+_qG89ZY_41dfs95FnouC0B+HJ8g@mail.gmail.com>
In-Reply-To: <fc4efe9f-69f4-4f58-9f7c-8f2e75a8e590@gmail.com>

Show 10 quoted lines

> >      ci: point leak-sanitizer failures at the actual test and error
> >
> >      I discovered while running CI on another GitHub pull request that it's
> >      very hard to see where the error is for the leak tests.
> >
> >      This will stop each leak-sanitizer script at its first failure and
> >      points annotations at the real file and error.
>
> Putting the leak output in the test results is very welcome, but does
> this mean that if there are two leaks we only report one?

It already had a behavior where one failure made every subsequent test in the script report "not ok" too, so lots of noise burying the real leaks.

Show 8 quoted lines

> >      Proof that it works:
> >      https://github.com/git/git/actions/runs/35871180948/job/107215430244
>
> Opening that link shows that the individual test failures are no-longer
> folded and I see some very strange scrolling behavior in firefox - when
> the page opens it scrolls to the bottom of the output of
> "ci/build-and-run-tests.sh" and if I try to scroll up it immediately
> scrolls back down as soon as my fingers leave the touchpad.

I'll take a look at that.

> The patch below seems to do more than just changing the output to
> display the leak backtrace - it adds some escaping and changes the
> annotations. There is no explanation of what these changes do or why
> they are required.

I'll expand the commit message.

Harald