Re: [PATCH v4 2/2] ci: point test failures and fixed known breakages at their file and line
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Oct 2, 2026, 08:04 UTC
- Message-ID
- <CAHwyqnWyKRd_K0VfEMKRd79AJa2ygcq3wfWOPKS2+YqJ5UYqWw@mail.gmail.com>
- In-Reply-To
- <0e0972b7-65a2-46ce-84a9-7e403620802a@gmail.com>
Show 8 quoted lines
> > A GitHub annotation is a single line, so a `%` in a test description > > has to be percent-encoded as `%25`, or GitHub misreads it as its own > > escape sequence. for-each-ref's format atoms use plenty of them, e.g. > > `%(raw)`. > > That's a useful example of why we want to escape the output which makes > it all the more puzzling that we don't escape the existing annotations > that I mentioned last time.
This feels like a rabbit hole and probably better to just drop the escaping altogether. It seems that the only thing that would need escaping is the literal '%25', '%' in ASCII, but it doesn't even appear in any of our tests. See:
- https://github.com/git/git/actions/runs/36976989079/job/110742888375?pr=2435 - https://github.com/git/git/actions/runs/36977041388/job/110743045462?pr=2436
I'll just drop this now. If needed, better to pick it up in a different topic. Thanks for pursuing this!
Harald