From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Sep 2026 14:37:13 GMT
Subject: Re: [PATCH v3 0/2] ci: link failure and leak annotations to the test script
Message-ID: <xmqqpkxudcva.fsf@gitster.g>
In-Reply-To: <pull.2419.v3.git.git.1790748583.gitgitgadget@gmail.com>

"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Link failure and leak annotations in CI to the test script, so both can be
> found from the job summary.
>
> V3 CI Job where failures and leaks are reported:
> https://github.com/git/git/actions/runs/36537917146/job/109306215909?pr=2426
>
> Changes in v3:
>
>  * Fixed bug in the --immediate exit ordering: the --immediate &&
>    --invert-exit-code path called exit 0 before the test's annotation was
>    written, now a single unconditional call covers both exit paths.
>  * github_escape_message_ no longer relies on \r being a portable sed escape
>    sequence (not POSIX-guaranteed and BSD sed implementations can differ),
>    it splices in the literal carriage-return byte via printf instead.
>  * Reverted unrelated test-tool line back to its original form.

With these updates, the patches look good to me.  Unless others
spot problems I failed to see, let me mark the topic for 'next'.

Thanks.