Re: [PATCH 1/3] perf: let's disable symlinks on Windows

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2016, 19:51 UTC
Message-ID: <xmqqoa8dofmu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1605101738390.4092@virtualbox>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 10 quoted lines

> In Git for Windows' SDK, Git's source code is always checked out
> with symlinks disabled. The reason is that POSIX symlinks have no
> accurate equivalent on Windows [*1*]. More precisely, though, it is
> not just Git's source code but *all* source code that is checked
> out with symlinks disabled: core.symlinks is set to false in the
> system-wide gitconfig.
>
> Since the perf tests are run with the system-wide gitconfig *disabled*,
> we have to make sure that the Git repository is initialized correctly
> by configuring core.symlinks explicitly.

Is MINGW the right prerequisite to use here, or is SIMLINKS more appropriate?

Show 24 quoted lines

>
> Footnote *1*:
> https://github.com/git-for-windows/git/wiki/Symbolic-Links
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  t/perf/perf-lib.sh | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
> index 5cf74ed..e9020d0 100644
> --- a/t/perf/perf-lib.sh
> +++ b/t/perf/perf-lib.sh
> @@ -97,6 +97,10 @@ test_perf_create_repo_from () {
>  		done &&
>  		cd .. &&
>  		git init -q &&
> +		if test_have_prereq MINGW
> +		then
> +			git config core.symlinks false
> +		fi &&
>  		mv .git/hooks .git/hooks-disabled 2>/dev/null
>  	) || error "failed to copy repository '$source' to '$repo'"
>  }