Re: [PATCH 2/3] perf: make the tests work in worktrees
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 11, 2016, 08:08 UTC
- Message-ID
- <alpine.DEB.2.20.1605111004020.4092@virtualbox>
- In-Reply-To
- <xmqq7ff1ody6.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Tue, 10 May 2016, Junio C Hamano wrote:
Show 20 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> > diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
> > index e9020d0..e5682f7 100644
> > --- a/t/perf/perf-lib.sh
> > +++ b/t/perf/perf-lib.sh
> > @@ -80,22 +80,22 @@ test_perf_create_repo_from () {
> > error "bug in the test script: not 2 parameters to test-create-repo"
> > repo="$1"
> > source="$2"
> > - source_git=$source/$(cd "$source" && git rev-parse --git-dir)
> > + source_git="$(cd "$source" && git rev-parse --git-dir)"
> > + objects_dir="$(git rev-parse --git-path objects)"
>
> I do not quite understand this change. Whose object_dir is this
> looking into? The original wanted to peek into $source/.git/objects/
> which may have been wrong when $source is borrowing from some other
> repository, but the new invocation of rev-parse --git-path objects
> is done inside what repository? It does not seem to pay any attention
> to $source and the change below just copies from there into $repo.Bah. This got messed up in one of my interactive rebases. And then I missed it in my final look-over before sending. Sorry. Fixed in v2.
Ciao, Dscho