git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/3] perf: make the tests work in worktrees

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 11, 2016, 08:42 UTC
Message-ID
<d783290cabe601ee8623044482b2992fb7936534.1462955446.git.johannes.schindelin@gmx.de>
In-Reply-To
<cover.1462955446.git.johannes.schindelin@gmx.de>

This patch makes perf-lib.sh more robust so that it can run correctly even inside a worktree. For example, it assumed that $GIT_DIR/objects is the objects directory (which is not the case for worktrees) and it used the commondir file verbatim, even if it contained a relative path.

Furthermore, the setup code expected `git rev-parse --git-dir` to spit out a relative path, which is also not true for worktrees. Let's just change the code to accept both relative and absolute paths, by avoiding the `cd` into the copied working directory.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/perf/perf-lib.sh | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
index 50c8c39..cb88b08 100644
--- a/t/perf/perf-lib.sh
+++ b/t/perf/perf-lib.sh
@@ -80,22 +80,22 @@ test_perf_create_repo_from () {
 	error "bug in the test script: not 2 parameters to test-create-repo"
 	repo="$1"
 	source="$2"
-	source_git=$source/$(cd "$source" && git rev-parse --git-dir)
+	source_git="$(cd "$source" && git rev-parse --git-dir)"
+	objects_dir="$(cd "$source" && git rev-parse --git-path objects)"
 	mkdir -p "$repo/.git"
 	(
-		cd "$repo/.git" &&
-		{ cp -Rl "$source_git/objects" . 2>/dev/null ||
-			cp -R "$source_git/objects" .; } &&
+		{ cp -Rl "$objects_dir" "$repo/.git/" 2>/dev/null ||
+			cp -R "$objects_dir" "$repo/.git/"; } &&
 		for stuff in "$source_git"/*; do
 			case "$stuff" in
-				*/objects|*/hooks|*/config)
+				*/objects|*/hooks|*/config|*/commondir)
 					;;
 				*)
-					cp -R "$stuff" . || exit 1
+					cp -R "$stuff" "$repo/.git/" || exit 1
 					;;
 			esac
 		done &&
-		cd .. &&
+		cd "$repo" &&
 		git init -q &&
 		git init -q && {
 			test_have_prereq SYMLINKS ||
-- 
2.8.2.465.gb077790
Previous: Johannes SchindelinNext: Eric Sunshine
Message 13 of 26 in “Introduce a perf test for interactive rebase”
  1. 0/3 Introduce a perf test for interactive rebaseJohannes Schindelin, May 10, 2016
  2. 1/3 perf: let's disable symlinks on WindowsJohannes Schindelin, May 10, 2016
  3. Junio C HamanoMay 10, 2016
  4. Johannes SchindelinMay 11, 2016
  5. 2/3 perf: make the tests work in worktreesJohannes Schindelin, May 10, 2016
  6. Junio C HamanoMay 10, 2016
  7. Johannes SchindelinMay 11, 2016
  8. 3/3 Add a perf test for rebase -iJohannes Schindelin, May 10, 2016
  9. 0/3 Introduce a perf test for interactive rebaseJohannes Schindelin, May 11, 2016
  10. 3/3 Add a perf test for rebase -iJohannes Schindelin, May 11, 2016
  11. Junio C HamanoMay 11, 2016
  12. Johannes SchindelinMay 13, 2016
  13. 2/3 perf: make the tests work in worktreesJohannes Schindelin, May 11, 2016
  14. Eric SunshineMay 11, 2016
  15. Johannes SchindelinMay 13, 2016
  16. 1/3 perf: let's disable symlinks when they are not availableJohannes Schindelin, May 11, 2016
  17. 0/3 Introduce a perf test for interactive rebaseJohannes Schindelin, May 13, 2016
  18. 1/3 perf: let's disable symlinks when they are not availableJohannes Schindelin, May 13, 2016
  19. 2/3 perf: make the tests work in worktreesJohannes Schindelin, May 13, 2016
  20. René ScharfeMay 29, 2016
  21. Johannes SchindelinMay 30, 2016
  22. Junio C HamanoMay 30, 2016
  23. René ScharfeMay 30, 2016
  24. Junio C HamanoMay 31, 2016
  25. Jeff KingJun 21, 2016
  26. 3/3 Add a perf test for rebase -iJohannes Schindelin, May 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.