[PATCH v2 1/3] perf: let's disable symlinks when they are not available
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 11, 2016, 08:42 UTC
- Message-ID
- <d651a7fdd7af6e1e7c32599bca9efeb6fd923e7c.1462955446.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1462955446.git.johannes.schindelin@gmx.de>
We already have a perfectly fine prereq to tell us whether it is safe to use symlinks. So let's use it.
This fixes the performance tests in Git for Windows' SDK, where symlinks are not really available ([*1*]). This is not an issue with Git for Windows itself because it configures core.symlinks=false in its system config. However, the system config is disabled for the performance tests, for obvious reasons: we want them to be independent of the vagaries of any local configuration.
Footnote *1*: Windows has symbolic links. Git for Windows disables them by default, though (for example: in standard setups, non-admins lack the privilege to create symbolic links). For details, see https://github.com/git-for-windows/git/wiki/Symbolic-Links
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- t/perf/perf-lib.sh | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index 5cf74ed..50c8c39 100644 --- a/t/perf/perf-lib.sh +++ b/t/perf/perf-lib.sh @@ -97,6 +97,10 @@ test_perf_create_repo_from () { done && cd .. && git init -q && + git init -q && { + test_have_prereq SYMLINKS || + git config core.symlinks false + } && mv .git/hooks .git/hooks-disabled 2>/dev/null ) || error "failed to copy repository '$source' to '$repo'" }
-- 2.8.2.465.gb077790