Re: [PATCH v2 10/10] add UNLEAK annotation for reducing leak false positives

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2017, 05:12 UTC
Message-ID: <xmqqo9q6nebe.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170920022838.tlkb5qlmctlstqb6@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> At any rate, I think Jonathan's point is that writing:
>
>   UNLEAK(foo)
>
> will silently pass in a normal build, and only much later will somebody
> run a leak-checking build and see the compile error.

Yeah, I think I understand that concern.

	#if SOME_CONDITION
	#define X(y) do_x(y)
	#else
	#define X(y) /* nothing */
	#endif

is something we quite often use, and I just found it a bit unusual that all of a sudden we start to be extra careful only with this macro.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.