Re: [PATCH for jk/leak-checkers] git-compat-util: make UNLEAK less error-prone

From: Jeff King <peff@peff.net>
Date: Sep 19, 2017, 21:46 UTC
Message-ID: <20170919214609.beair2zraemibai2@sigill.intra.peff.net>
In-Reply-To: <20170919213456.13983-1-jonathantanmy@google.com>

On Tue, Sep 19, 2017 at 02:34:56PM -0700, Jonathan Tan wrote:

Show 7 quoted lines

> Commit 0e5bba5 ("add UNLEAK annotation for reducing leak false
> positives", 2017-09-08) introduced an UNLEAK macro to be used as
> "UNLEAK(var);", but its existing definitions make it possible to be
> invoked as "UNLEAK(var)" (without the trailing semicolon) too.
> 
> Therefore, modify its definitions to cause a compile-time error if
> invoked without the trailing semicolon.

The patch itself looks good, but I think your commit message dances around the real motivation: some parsers may complain about doubled semicolons, or semicolons without an associated line of code (which is really just a doubled semicolon, too, I guess).

-Peff