[PATCH 05/10] config: plug user_config leak
- From
Jeff King <peff@peff.net>
- Date
- Sep 5, 2017, 13:04 UTC
- Message-ID
- <20170905130419.q27w6nblsryegldg@sigill.intra.peff.net>
- In-Reply-To
- <20170905130149.agc3zp3s6i6e5aki@sigill.intra.peff.net>
We generate filenames for the user_config ("~/.gitconfig") and the xdg config ("$XDG_CONFIG_HOME/git/config") and then decide which to use by looking at the filesystem. But after selecting one, the unused string is just leaked.
This is a tiny leak, but it creates noise in leak-checker output.
Signed-off-by: Jeff King <peff@peff.net> --- builtin/config.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/builtin/config.c b/builtin/config.c index 70ff231e9c..52a4606243 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -518,10 +518,13 @@ int cmd_config(int argc, const char **argv, const char *prefix) die("$HOME not set"); if (access_or_warn(user_config, R_OK, 0) && - xdg_config && !access_or_warn(xdg_config, R_OK, 0)) + xdg_config && !access_or_warn(xdg_config, R_OK, 0)) { given_config_source.file = xdg_config; - else + free(user_config); + } else { given_config_source.file = user_config; + free(xdg_config); + } } else if (use_system_config) given_config_source.file = git_etc_gitconfig();
-- 2.14.1.721.gc5bc1565f1