[PATCH 01/10] test-lib: --valgrind should not override --verbose-log

From: Jeff King <peff@peff.net>
Date: Sep 5, 2017, 13:03 UTC
Message-ID: <20170905130354.ydaasossmjlaps22@sigill.intra.peff.net>
In-Reply-To: <20170905130149.agc3zp3s6i6e5aki@sigill.intra.peff.net>

The --verbose test option cannot be used with test harnesses like "prove". Instead, you must use --verbose-log.

Since the --valgrind option implies --verbose, that means that it cannot be used with prove. I.e., this does not work:

  prove t0000-basic.sh :: --valgrind

You'd think it could be fixed by doing:

  prove t0000-basic.sh :: --valgrind --verbose-log

but that doesn't work either, because the implied --verbose takes precedence over --verbose-log. If the user has given us a specific option, we should prefer that.

Signed-off-by: Jeff King <peff@peff.net>
---
I ended up not using valgrind for most of my tests, but this did bite me
early on when I tried to run "make GIT_TEST_OPTS=--valgrind prove".

 t/test-lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 5fbd8d4a90..62461a6e35 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -274,7 +274,7 @@ then
 	test -z "$verbose" && verbose_only="$valgrind_only"
 elif test -n "$valgrind"
 then
-	verbose=t
+	test -z "$verbose_log" && verbose=t
 fi
 
 if test -n "$color"

-- 
2.14.1.721.gc5bc1565f1