Re: [PATCH] urlmatch: create fetch.credentialsInUrl config

From: Junio C Hamano <gitster@pobox.com>
Date: May 23, 2022, 21:14 UTC
Message-ID: <xmqqo7zoostd.fsf@gitster.g>
In-Reply-To: <7495dac8-0241-ad56-59e3-100673c88c52@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

> This computation of at_ptr matches the one in url_normalize_1(),
> so it at least agrees about where the "username[:password]" section
> could be.

OK.

> That does mean that the password cannot contain an "@"
> symbol (unless it is special-cased somehow?).

I wasn't worried about what is valid but more about what attackers can fool users to throw at "git clone" and make our code misbehave (which can include garbage that would not parse correctly).

I think the while() loop will just become a no-op, anonymized buffer is left empty and colon_ptr does not get updated at all. Then strbuf_addstr() after the loop will put everything from '@' to the strbuf to be showed, and none of these should lead to any overrun or exploit.

Thanks.