Re: [PATCH v3 2/2] usage: add warn_once() helper for repeated warnings

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 1, 2022, 20:21 UTC
Message-ID: <xmqq35gorv7c.fsf@gitster.g>
In-Reply-To: <8f96563b-87c5-2a8c-fe35-19fd0cc3c7d2@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

> We could certainly investigate this more, but it seems like a more
> problematic approach than the one taken here. We could add a "is_valid"
> bit to struct remote, but then could some code path modify that struct
> after it was validated?

Two separate parser parsing the same string to produce (supposedly) equivalent parse results is a bit disturbing, and I am not sure if "is_valid" bit helps that.

Adding "user" and "password" members to the struct, and retire the existing "parser" (instead it would just use the pre-parsed components stored in the struct) would. It would be a much more involved change, and it is something more than we would want to do in a regression fix patch.

But this series is a new feature development, so...