Re: [PATCH v4] remote: create fetch.credentialsInUrl config

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 6, 2022, 15:37 UTC
Message-ID: <xmqqa6apdcrb.fsf@gitster.g>
In-Reply-To: <c414de1f-b742-0880-09e6-446f1212e3bd@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 10 quoted lines

> On 6/2/2022 5:20 PM, Junio C Hamano wrote:
> ...
>> Taking all together, I'll queue the following on top as a separate
>> fix-up patch, but I may well be giving (some) bad pieces of advice,
>> so I will wait for others to comment.
>
> I cut all of your commentary because it was universally good and
> the fixup you provided does a great job of solving those issues.
>
> Please give yourself co-authorship on the squashed commit.

Heh, that's at most helped-by; a small bugfix in the logic (zero-length) and all others are minor clean-ups.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.