Re: [PATCH v3 2/2] usage: add warn_once() helper for repeated warnings

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2022, 17:53 UTC
Message-ID: <xmqqilpjne95.fsf@gitster.g>
In-Reply-To: <376e65b1-3001-9bf8-8d08-dcfd9c6a8caf@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 5 quoted lines

> Yes, you're right. I should use the output 'struct url_inf' from
> url_normalize() to construct the redacted URL. It has the downside
> that the output URL can be slightly different from the input URL,
> but a user should still be able to diagnose how to resolve the
> situation.

Ah, the error message is based on pre-normalization which may very well be different, as that is the whole point of normalization ;-)

We'd redact password part in the error message anyway, so it may not be a huge deal.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.