Re: [PATCH v5 3/6] protocol-caps: initialization bug fix

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 29, 2022, 17:51 UTC
Message-ID: <xmqqo7x77qp6.fsf@gitster.g>
In-Reply-To: <20220728230210.2952731-4-calvinwan@google.com>

Calvin Wan <calvinwan@google.com> writes:

Show 9 quoted lines

> Initialize info. If info.size bit was on due to on-stack garbage,
> we would have given our response with "size" attribute prefixed,
> even when the client side never requested it.
>
> Signed-off-by: Calvin Wan <calvinwan@google.com>
> Helped-by: Jonathan Tan <jonathantanmy@google.com>
> ---
>  protocol-caps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

OK, this is new in this round and it makes sense.

Show 12 quoted lines

> diff --git a/protocol-caps.c b/protocol-caps.c
> index bbde91810a..2ad9f45c59 100644
> --- a/protocol-caps.c
> +++ b/protocol-caps.c
> @@ -77,7 +77,7 @@ static void send_info(struct repository *r, struct packet_writer *writer,
>  
>  int cap_object_info(struct repository *r, struct packet_reader *request)
>  {
> -	struct requested_info info;
> +	struct requested_info info = { 0 };
>  	struct packet_writer writer;
>  	struct string_list oid_str_list = STRING_LIST_INIT_DUP;