git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] fetch —object-info-format: client option for object-info

From
Philip Oakley <philipoakley@iee.email>
Date
Feb 9, 2022, 12:48 UTC
Message-ID
<e21c4f77-061c-d125-97cb-1a8cb7692e56@iee.email>
In-Reply-To
<20220208235631.732466-1-calvinwan@google.com>
On 08/02/2022 23:56, Calvin Wan wrote:
Show 50 quoted lines
> Add ‘—object-info-format’ option to fetch. This option allows
> the client to make an object-info [1] command request to a server
> that supports protocol v2.
>
> The transport implementation uses vtables [2], similar to how Git
> fetches refs, to determine whether a process needs to be taken over
> before sending the object-info request. Different protocols
> require different setups for making requests.
>
> [1] https://lore.kernel.org/git/20210420233830.2181153-1-bga@google.com/
> [2] https://lore.kernel.org/git/26f276956001a120cc9105b0071762c2fd4a45c5.15=
> 13287544.git.jonathantanmy@google.com/
>
> Helped-by: Jonathan Tan <jonathantanmy@google.com>
> Signed-off-by: Calvin Wan <calvinwan@google.com>
>
> ---
> Please ignore the patch above. It was sent with a stale patch message.
>  builtin/fetch.c              | 26 ++++++++++++
>  fetch-pack.c                 | 53 +++++++++++++++++++++++
>  fetch-pack.h                 |  7 ++++
>  t/t5583-fetch-object-info.sh | 81 ++++++++++++++++++++++++++++++++++++
>  transport-helper.c           | 12 ++++++
>  transport-internal.h         |  1 +
>  transport.c                  | 59 ++++++++++++++++++++++++++
>  transport.h                  |  1 +
>  8 files changed, 240 insertions(+)
>  create mode 100755 t/t5583-fetch-object-info.sh
>
> diff --git a/builtin/fetch.c b/builtin/fetch.c
> index 5f06b21f8e..b48d9e93d0 100644
> --- a/builtin/fetch.c
> +++ b/builtin/fetch.c
> @@ -29,6 +29,9 @@
>  #include "commit-graph.h"
>  #include "shallow.h"
>  #include "worktree.h"
> +#include "protocol.h"
> +#include "pkt-line.h"
> +#include "connect.h"
>  
>  #define FORCED_UPDATES_DELAY_WARNING_IN_MS (10 * 1000)
>  
> @@ -37,6 +40,7 @@ static const char * const builtin_fetch_usage[] = {
>  	N_("git fetch [<options>] <group>"),
>  	N_("git fetch --multiple [<options>] [(<repository> | <group>)...]"),
>  	N_("git fetch --all [<options>]"),
> +	N_("git fetch --object-info-format=[<arguments>] <remote> [<object-ids>]"),
>  	NULL
>  };

Doesn't this also need a matching Documentarian update for the option? -- Philip

Previous: Calvin WanNext: Calvin Wan
Message 3 of 103 in “fetch —object-info-format: client option for object-info”
  1. fetch —object-info-format: client option for object-infoCalvin Wan, Feb 8, 2022
  2. fetch —object-info-format: client option for object-infoCalvin Wan, Feb 8, 2022
  3. Philip OakleyFeb 9, 2022
  4. Calvin WanFeb 10, 2022
  5. Jonathan TanFeb 9, 2022
  6. Calvin WanFeb 10, 2022
  7. 0/3 object-info: add option for retrieving object infoCalvin Wan, Mar 28, 2022
  8. 1/3 fetch-pack: refactor packet writing and fetch optionsCalvin Wan, Mar 28, 2022
  9. Junio C HamanoMar 29, 2022
  10. Taylor BlauMar 29, 2022
  11. Jonathan TanMar 30, 2022
  12. 2/3 transfer.advertiseObjectInfo: add object-info configCalvin Wan, Mar 28, 2022
  13. Junio C HamanoMar 29, 2022
  14. Calvin WanMar 29, 2022
  15. Taylor BlauMar 29, 2022
  16. 3/3 object-info: add option for retrieving object infoCalvin Wan, Mar 28, 2022
  17. Junio C HamanoMar 29, 2022
  18. Junio C HamanoMar 29, 2022
  19. Junio C HamanoMar 30, 2022
  20. Calvin WanMar 30, 2022
  21. Jonathan TanMar 30, 2022
  22. Junio C HamanoMar 30, 2022
  23. Taylor BlauMar 29, 2022
  24. Calvin WanMar 30, 2022
  25. John CaiMar 30, 2022
  26. Calvin WanMar 31, 2022
  27. Junio C HamanoApr 1, 2022
  28. Jonathan TanMar 30, 2022
  29. Josh SteadmonMar 30, 2022
  30. Calvin WanMar 30, 2022
  31. Junio C HamanoMar 29, 2022
  32. Calvin WanMar 29, 2022
  33. Junio C HamanoMar 31, 2022
  34. 0/8 cat-file: add --batch-command remote-object-info commandCalvin Wan, May 2, 2022
  35. 1/8 fetch-pack: refactor packet writingCalvin Wan, May 2, 2022
  36. 3/8 object-store: add function to free object_info contentsCalvin Wan, May 2, 2022
  37. Junio C HamanoMay 2, 2022
  38. Junio C HamanoMay 4, 2022
  39. Junio C HamanoMay 5, 2022
  40. Calvin WanMay 5, 2022
  41. Junio C HamanoMay 5, 2022
  42. 4/8 object-info: send attribute packet regardless of object idsCalvin Wan, May 2, 2022
  43. Junio C HamanoMay 3, 2022
  44. Calvin WanMay 3, 2022
  45. Jonathan TanMay 3, 2022
  46. 2/8 fetch-pack: move fetch default settingsCalvin Wan, May 2, 2022
  47. Junio C HamanoMay 2, 2022
  48. Jonathan TanMay 3, 2022
  49. Calvin WanMay 5, 2022
  50. 5/8 transport: add client side capability to request object-infoCalvin Wan, May 2, 2022
  51. Junio C HamanoMay 3, 2022
  52. Calvin WanMay 3, 2022
  53. Junio C HamanoMay 4, 2022
  54. Jonathan TanMay 3, 2022
  55. Junio C HamanoMay 4, 2022
  56. 7/8 cat-file: move parse_cmd and DEFAULT_FORMAT upCalvin Wan, May 2, 2022
  57. 6/8 transport: add object-info fallback to fetchCalvin Wan, May 2, 2022
  58. Jonathan TanMay 3, 2022
  59. 8/8 cat-file: add --batch-command remote-object-info commandCalvin Wan, May 2, 2022
  60. Jonathan TanMay 4, 2022
  61. Calvin WanMay 5, 2022
  62. Junio C HamanoMay 5, 2022
  63. Junio C HamanoMay 5, 2022
  64. Calvin WanMay 5, 2022
  65. ZheNing HuJul 31, 2022
  66. Calvin WanAug 8, 2022
  67. 0/6 cat-file: add --batch-command remote-object-info commandCalvin Wan, Jul 28, 2022
  68. Junio C HamanoJul 28, 2022
  69. Junio C HamanoJul 29, 2022
  70. Phillip WoodJul 31, 2022
  71. Calvin WanAug 4, 2022
  72. Junio C HamanoSep 30, 2022
  73. 1/6 fetch-pack: refactor packet writingCalvin Wan, Jul 28, 2022
  74. 2/6 fetch-pack: move fetch initializationCalvin Wan, Jul 28, 2022
  75. 3/6 protocol-caps: initialization bug fixCalvin Wan, Jul 28, 2022
  76. Junio C HamanoJul 29, 2022
  77. 4/6 serve: advertise object-info featureCalvin Wan, Jul 28, 2022
  78. Junio C HamanoJul 29, 2022
  79. Calvin WanAug 1, 2022
  80. Ævar Arnfjörð BjarmasonAug 1, 2022
  81. Junio C HamanoAug 1, 2022
  82. Calvin WanAug 1, 2022
  83. 5/6 transport: add client support for object-infoCalvin Wan, Jul 28, 2022
  84. Junio C HamanoJul 29, 2022
  85. Calvin WanAug 4, 2022
  86. Phillip WoodAug 1, 2022
  87. Calvin WanAug 4, 2022
  88. Phillip WoodAug 8, 2022
  89. Phillip WoodAug 1, 2022
  90. Phillip WoodAug 8, 2022
  91. 6/6 cat-file: add remote-object-info to batch-commandCalvin Wan, Jul 28, 2022
  92. Ævar Arnfjörð BjarmasonJul 29, 2022
  93. ZheNing HuAug 7, 2022
  94. Calvin WanAug 8, 2022
  95. Ævar Arnfjörð BjarmasonAug 11, 2022
  96. Junio C HamanoJul 29, 2022
  97. Calvin WanAug 8, 2022
  98. Ævar Arnfjörð BjarmasonSep 28, 2022
  99. ZheNing HuJul 31, 2022
  100. Calvin WanAug 8, 2022
  101. Junio C HamanoAug 13, 2022
  102. John CaiFeb 9, 2022
  103. Calvin WanFeb 10, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.