git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 6/6] cat-file: add remote-object-info to batch-command

From
Calvin Wan <calvinwan@google.com>
Date
Aug 8, 2022, 18:07 UTC
Message-ID
<CAFySSZBPoJC8je2jr4_nrrzdFG3=HuRcou6qjrJTNOzue1pvgQ@mail.gmail.com>
In-Reply-To
<220729.86tu70ig47.gmgdl@evledraar.gmail.com>
Show 5 quoted lines
> > Since the `info` command in cat-file --batch-command prints object info
> > for a given object, it is natural to add another command in cat-file
> > --batch-command to print object info for a given object from a remote.
>
> Is it ?:)
Haha yes this could use a little rewording
Show 29 quoted lines
> > Add `remote-object-info` to cat-file --batch-command.
>
> I realize this bit of implementation changed in v4, i.e. it used to be
> in "fetch", and I'm happy to have it moved out of there, we don't need
> to overload it more.
>
> But I remember thinking (and perhaps commenting on-list, I can't
> remember) that the "object-info" server verb was a bit odd at the time
> that it was implemented. I understand the motivation, but surely it was
> stumbling its way towards being something more generic, i.e. being able
> to just expose cmd_cat_file() in some form.
>
> Which is one of the goals I've had in mind with working on fixing memory
> leaks in various places, i.e. once you get common commands to clean up
> after themselves it usually becomes to have a "command server".
>
> So (and I don't mind if this is longer term, just asking), is there a
> reason for why we wouldn't want to do away with object-info and this
> "cat-file talks to a remote", in favor of just having support for
> invoking arbitrary commands from a remote.
>
> Of course that set of allowed RCE commands would be zero by default, but
> if we had some way to define tha "cat-file" was allowed to be called,
> and only if you invoked:
>
>         cat-file --batch="%(objectsize)"
>
> Or whatever, but over the v2 protocol, wouldn't we basically have
> object-info in a more roundabout way?

While I do think that if we did have a set of allowed RCE commands, this would be a good candidate to be one of those commands. I am worried about security, maintainability, and server performance risks this change would also carry. Figuring out which commands are secure and would not overload the server, and then maintaining that set seems like a much more worrisome design than having a secure git server.

Previous: ZheNing HuNext: Ævar Arnfjörð Bjarmason
Message 94 of 103 in “fetch —object-info-format: client option for object-info”
  1. fetch —object-info-format: client option for object-infoCalvin Wan, Feb 8, 2022
  2. fetch —object-info-format: client option for object-infoCalvin Wan, Feb 8, 2022
  3. Philip OakleyFeb 9, 2022
  4. Calvin WanFeb 10, 2022
  5. Jonathan TanFeb 9, 2022
  6. Calvin WanFeb 10, 2022
  7. 0/3 object-info: add option for retrieving object infoCalvin Wan, Mar 28, 2022
  8. 1/3 fetch-pack: refactor packet writing and fetch optionsCalvin Wan, Mar 28, 2022
  9. Junio C HamanoMar 29, 2022
  10. Taylor BlauMar 29, 2022
  11. Jonathan TanMar 30, 2022
  12. 2/3 transfer.advertiseObjectInfo: add object-info configCalvin Wan, Mar 28, 2022
  13. Junio C HamanoMar 29, 2022
  14. Calvin WanMar 29, 2022
  15. Taylor BlauMar 29, 2022
  16. 3/3 object-info: add option for retrieving object infoCalvin Wan, Mar 28, 2022
  17. Junio C HamanoMar 29, 2022
  18. Junio C HamanoMar 29, 2022
  19. Junio C HamanoMar 30, 2022
  20. Calvin WanMar 30, 2022
  21. Jonathan TanMar 30, 2022
  22. Junio C HamanoMar 30, 2022
  23. Taylor BlauMar 29, 2022
  24. Calvin WanMar 30, 2022
  25. John CaiMar 30, 2022
  26. Calvin WanMar 31, 2022
  27. Junio C HamanoApr 1, 2022
  28. Jonathan TanMar 30, 2022
  29. Josh SteadmonMar 30, 2022
  30. Calvin WanMar 30, 2022
  31. Junio C HamanoMar 29, 2022
  32. Calvin WanMar 29, 2022
  33. Junio C HamanoMar 31, 2022
  34. 0/8 cat-file: add --batch-command remote-object-info commandCalvin Wan, May 2, 2022
  35. 1/8 fetch-pack: refactor packet writingCalvin Wan, May 2, 2022
  36. 3/8 object-store: add function to free object_info contentsCalvin Wan, May 2, 2022
  37. Junio C HamanoMay 2, 2022
  38. Junio C HamanoMay 4, 2022
  39. Junio C HamanoMay 5, 2022
  40. Calvin WanMay 5, 2022
  41. Junio C HamanoMay 5, 2022
  42. 4/8 object-info: send attribute packet regardless of object idsCalvin Wan, May 2, 2022
  43. Junio C HamanoMay 3, 2022
  44. Calvin WanMay 3, 2022
  45. Jonathan TanMay 3, 2022
  46. 2/8 fetch-pack: move fetch default settingsCalvin Wan, May 2, 2022
  47. Junio C HamanoMay 2, 2022
  48. Jonathan TanMay 3, 2022
  49. Calvin WanMay 5, 2022
  50. 5/8 transport: add client side capability to request object-infoCalvin Wan, May 2, 2022
  51. Junio C HamanoMay 3, 2022
  52. Calvin WanMay 3, 2022
  53. Junio C HamanoMay 4, 2022
  54. Jonathan TanMay 3, 2022
  55. Junio C HamanoMay 4, 2022
  56. 7/8 cat-file: move parse_cmd and DEFAULT_FORMAT upCalvin Wan, May 2, 2022
  57. 6/8 transport: add object-info fallback to fetchCalvin Wan, May 2, 2022
  58. Jonathan TanMay 3, 2022
  59. 8/8 cat-file: add --batch-command remote-object-info commandCalvin Wan, May 2, 2022
  60. Jonathan TanMay 4, 2022
  61. Calvin WanMay 5, 2022
  62. Junio C HamanoMay 5, 2022
  63. Junio C HamanoMay 5, 2022
  64. Calvin WanMay 5, 2022
  65. ZheNing HuJul 31, 2022
  66. Calvin WanAug 8, 2022
  67. 0/6 cat-file: add --batch-command remote-object-info commandCalvin Wan, Jul 28, 2022
  68. Junio C HamanoJul 28, 2022
  69. Junio C HamanoJul 29, 2022
  70. Phillip WoodJul 31, 2022
  71. Calvin WanAug 4, 2022
  72. Junio C HamanoSep 30, 2022
  73. 1/6 fetch-pack: refactor packet writingCalvin Wan, Jul 28, 2022
  74. 2/6 fetch-pack: move fetch initializationCalvin Wan, Jul 28, 2022
  75. 3/6 protocol-caps: initialization bug fixCalvin Wan, Jul 28, 2022
  76. Junio C HamanoJul 29, 2022
  77. 4/6 serve: advertise object-info featureCalvin Wan, Jul 28, 2022
  78. Junio C HamanoJul 29, 2022
  79. Calvin WanAug 1, 2022
  80. Ævar Arnfjörð BjarmasonAug 1, 2022
  81. Junio C HamanoAug 1, 2022
  82. Calvin WanAug 1, 2022
  83. 5/6 transport: add client support for object-infoCalvin Wan, Jul 28, 2022
  84. Junio C HamanoJul 29, 2022
  85. Calvin WanAug 4, 2022
  86. Phillip WoodAug 1, 2022
  87. Calvin WanAug 4, 2022
  88. Phillip WoodAug 8, 2022
  89. Phillip WoodAug 1, 2022
  90. Phillip WoodAug 8, 2022
  91. 6/6 cat-file: add remote-object-info to batch-commandCalvin Wan, Jul 28, 2022
  92. Ævar Arnfjörð BjarmasonJul 29, 2022
  93. ZheNing HuAug 7, 2022
  94. Calvin WanAug 8, 2022
  95. Ævar Arnfjörð BjarmasonAug 11, 2022
  96. Junio C HamanoJul 29, 2022
  97. Calvin WanAug 8, 2022
  98. Ævar Arnfjörð BjarmasonSep 28, 2022
  99. ZheNing HuJul 31, 2022
  100. Calvin WanAug 8, 2022
  101. Junio C HamanoAug 13, 2022
  102. John CaiFeb 9, 2022
  103. Calvin WanFeb 10, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.