Re: [PATCH v2 1/4] test: refactor to use "test_grep"

From: Junio C Hamano <gitster@pobox.com>
Date: May 12, 2025, 13:42 UTC
Message-ID: <xmqqo6vyvtcf.fsf@gitster.g>
In-Reply-To: <4f92a1b4c24a6942fc55d305865bb55833d13c45.1746884789.git.gitgitgadget@gmail.com>

"Leon Michalak via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 10 quoted lines

> From: Leon Michalak <leonmichalak6@gmail.com>
>
> Refactor to use the modern "test_grep" test utility instead of regular
> "grep" which provides better debug information if tests fail.
>
> This is a prerequisite to the commits that follow which add to both test
> files.
>
> Signed-off-by: Leon Michalak <leonmichalak6@gmail.com>
> ---

These mostly look sensible, but I would title & phrase the commit description to 'use "test_grep"', not 'refactor to &'. It's shorter and more direct ;-)

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.