Re: [PATCH 3/3] add-interactive: add new "context" subcommand

From: Leon Michalak <leonmichalak6@gmail.com>
Date: May 6, 2025, 17:25 UTC
Message-ID: <CAP9jKjF2y48Zo6wSFPBN9OZy+iOhwmWPThVEt0o+9A0CASHXHA@mail.gmail.com>
In-Reply-To: <xmqqldr9lmpg.fsf@gitster.g>

On Tue, 6 May 2025 at 17:37, Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> Hmph, in the real UI, the first letters of these commands (which
> have deliberately been chosen to be unique) are shown in different
> color to hint that the answer to the prompt can be like 's' (for
> status).  I would hate to see that quit/help, which are somewhat
> special, move from the very end position.

This is the main reason I chose to put the new subcommand before as I also feel quit/help are better suited to be last, although I do see the argument against muscle memory and is valid.

> Perhaps the example of the documentation page shown above should
> respond with 's', not '1' to show more prominently that it is
> possible and encouraged?  I dunno.

Writing the first letters as opposed to the numbers is how I personally use this, just to add another perspective.

Would "config" as opposed to "settings" fix the unique lettering problem? Or perhaps config is not the best description for what it would do (I sometimes find myself using config/settings interchangeably but the majority may not...)?

Overall I feel the first two patches cover my use case the most so I am also not opposed to completely dropping the last patch about the `--interactive` context subcommand. Inherited diff context and command line overrides I feel are a great base to begin with either way. Just some thoughts :)