Re: [PATCH v4 0/4] Better support for customising context lines in --patch commands

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Jul 22, 2025, 16:05 UTC
Message-ID: <49703ba5-5f2a-4e91-b9c7-5500720d5d3d@gmail.com>
In-Reply-To: <xmqqfrepzdxd.fsf@gitster.g>

On 21/07/2025 17:50, Junio C Hamano wrote:

Show 9 quoted lines

> "Leon Michalak via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> Changes since v3:
>>
>>   * Update commit descriptions
>>   * Read struct properties directly instead of assigning to variables first
>>   * Simplify config setting / error checking
>>   * Remove redundant tests in later commit as they were replaced with better
>>     test(s)

I've left some comments on patch 4 about this. It seems to me that it is deleting useful tests and replacing them with redundant tests.

>>   * Change tests to use single quotes (this messes with the grep so was
>>     unable to explicitly test single quotes in the error messages, so decided
>>     to use regex . instead, which is what some other tests that have this
>>     problem seem to use as well)

Thanks for doing that

> 
> All of the above looked reasonably well done.  Will replace.
> 
> Unless there are objections, let me mark the topic for 'next' soonish.

I think we want to sort out the test changes in patch 4. Previously we discussed centralizing the option parsing in that patch as well but we can always do that as a follow up later.

Thanks

Phillip