Re: [PATCH] t1017: add missing quotes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 18, 2026, 17:08 UTC
- Message-ID
- <xmqqo6bm6p9v.fsf@gitster.g>
- In-Reply-To
- <20261118155935.60345-1-jakub.kulik@oracle.com>
Jakub Kulik <jakub.kulik@oracle.com> writes:
Show 8 quoted lines
> Signed-off-by: Jakub Kulik <jakub.kulik@oracle.com> > --- >> Strictly speaking, POSIX compliant shells do not require such >> quoting for pathnames that are used as redirection target. > > Indeed; when I run it with `bash --posix`, the test passes. > > Here is the patch with space between > and the filename removed.
Thanks.
I would fabricate a log message to say something about our CodingGuidelines ask you to quote variable references used for redirection targets or sources while queuing.
Show 26 quoted lines
> > t/t1017-cat-file-remote-object-info.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t1017-cat-file-remote-object-info.sh b/t/t1017-cat-file-remote-object-info.sh > index e2919aa061..8a04cfdae8 100755 > --- a/t/t1017-cat-file-remote-object-info.sh > +++ b/t/t1017-cat-file-remote-object-info.sh > @@ -69,7 +69,7 @@ daemon_parent=$GIT_DAEMON_DOCUMENT_ROOT_PATH/parent > > test_expect_success 'create repo to be served by git-daemon' ' > git init "$daemon_parent" && > - echo_without_newline "$hello_content" > $daemon_parent/hello && > + echo_without_newline "$hello_content" >"$daemon_parent/hello" && > git -C "$daemon_parent" update-index --add hello && > git -C "$daemon_parent" config transfer.advertiseobjectinfo true && > git clone "$GIT_DAEMON_URL/parent" -n "$daemon_parent/daemon_client_empty" > @@ -519,7 +519,7 @@ test_expect_success 'create repo to be served by http:// transport' ' > git init "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" && > git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config http.receivepack true && > git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config transfer.advertiseobjectinfo true && > - echo_without_newline "$hello_content" > $HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello && > + echo_without_newline "$hello_content" >"$HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello" && > git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" update-index --add hello && > git clone "$HTTPD_URL/smart/http_parent" -n "$HTTPD_DOCUMENT_ROOT_PATH/http_client_empty" > '