threads / discuss / 66835

several unquoted shell variables causing test failures on Solaris

Subject: several unquoted shell variables causing test failures on Solaris

## tl;dr

4 messages between Nov 12, 2026 and Nov 18, 2026.

replies: 3people: 2as markdown or json

Jakub Kulik· Nov 12, 2026, 15:39 UTC · lore
Hi, when running tests on Solaris, I encountered several test failures in 't1017-cat-file-remote-object-info.sh' which look like this:

./test-lib.sh: line 1040: cd: /builds/components/git/build/amd64/t/trash directory.t1017-cat-file-remote-object-info/repo/parent/daemon_client_empty: No such file or directory not ok 12 - requesting only objectname echoes back

The reason seems to be several unquoted variables (needed because of the space in path), and with the following change, the test is fixed again:

--- git-2.56.0/t/t1017-cat-file-remote-object-info.sh +++ git-2.56.0/t/t1017-cat-file-remote-object-info.sh

@@ -69,7 +69,7 @@ daemon_parent=$GIT_DAEMON_DOCUMENT_ROOT_
 
 test_expect_success 'create repo to be served by git-daemon' '
      git init "$daemon_parent" &&
-     echo_without_newline "$hello_content" > $daemon_parent/hello &&
+     echo_without_newline "$hello_content" > "$daemon_parent/hello" &&
      git -C "$daemon_parent" update-index --add hello &&
      git -C "$daemon_parent" config transfer.advertiseobjectinfo true &&
      git clone "$GIT_DAEMON_URL/parent" -n "$daemon_parent/daemon_client_empty"
@@ -519,7 +519,7 @@ test_expect_success 'create repo to be s
      git init "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
      git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config http.receivepack true &&
      git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config transfer.advertiseobjectinfo true &&
-     echo_without_newline "$hello_content" > $HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello &&
+     echo_without_newline "$hello_content" > "$HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello" &&
      git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" update-index --add hello &&
      git clone "$HTTPD_URL/smart/http_parent" -n "$HTTPD_DOCUMENT_ROOT_PATH/http_client_empty"
 '

Best Regards,
Jakub
Junio C Hamano· Nov 12, 2026, 20:56 UTC · re: Jakub Kulik · lore

Re: several unquoted shell variables causing test failures on Solaris

Jakub Kulik <jakub.kulik@oracle.com> writes:
Show 8 quoted lines
> Hi, when running tests on Solaris, I encountered several test failures in 't1017-cat-file-remote-object-info.sh' which look like this:
>
> ./test-lib.sh: line 1040: cd: /builds/components/git/build/amd64/t/trash directory.t1017-cat-file-remote-object-info/repo/parent/daemon_client_empty: No such file or directory
> not ok 12 - requesting only objectname echoes back
>
> The reason seems to be several unquoted variables (needed because
> of the space in path), and with the following change, the test is
> fixed again:

Strictly speaking, POSIX compliant shells do not require such quoting for pathnames that are used as redirection target.

But some shells are buggy, and our Documentation/CodingGuidelines do require them to be quoted. It also does require there is no space between redirection operator '>' and the filename, so the correct formulation would be:

> -     echo_without_newline "$hello_content" > $daemon_parent/hello &&
> +     echo_without_newline "$hello_content" > "$daemon_parent/hello" &&
	echo_without_newline "$hello_content" >"$daemon_parent/hello" &&
Care to submit an official fix with commit log message and sign off?
Thanks.
Jakub Kulik· Nov 18, 2026, 15:59 UTC · re: Junio C Hamano · lore

[PATCH] t1017: add missing quotes

Signed-off-by: Jakub Kulik <jakub.kulik@oracle.com>
---
> Strictly speaking, POSIX compliant shells do not require such
> quoting for pathnames that are used as redirection target.
Indeed; when I run it with `bash --posix`, the test passes.
Here is the patch with space between > and the filename removed.
 t/t1017-cat-file-remote-object-info.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t1017-cat-file-remote-object-info.sh b/t/t1017-cat-file-remote-object-info.sh
index e2919aa061..8a04cfdae8 100755
--- a/t/t1017-cat-file-remote-object-info.sh
+++ b/t/t1017-cat-file-remote-object-info.sh
@@ -69,7 +69,7 @@ daemon_parent=$GIT_DAEMON_DOCUMENT_ROOT_PATH/parent
 
 test_expect_success 'create repo to be served by git-daemon' '
 	git init "$daemon_parent" &&
-	echo_without_newline "$hello_content" > $daemon_parent/hello &&
+	echo_without_newline "$hello_content" >"$daemon_parent/hello" &&
 	git -C "$daemon_parent" update-index --add hello &&
 	git -C "$daemon_parent" config transfer.advertiseobjectinfo true &&
 	git clone "$GIT_DAEMON_URL/parent" -n "$daemon_parent/daemon_client_empty"
@@ -519,7 +519,7 @@ test_expect_success 'create repo to be served by http:// transport' '
 	git init "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
 	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config http.receivepack true &&
 	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config transfer.advertiseobjectinfo true &&
-	echo_without_newline "$hello_content" > $HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello &&
+	echo_without_newline "$hello_content" >"$HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello" &&
 	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" update-index --add hello &&
 	git clone "$HTTPD_URL/smart/http_parent" -n "$HTTPD_DOCUMENT_ROOT_PATH/http_client_empty"
 '
-- 
2.51.0
Junio C Hamano· Nov 18, 2026, 17:08 UTC · re: Jakub Kulik · lore

Re: [PATCH] t1017: add missing quotes

Jakub Kulik <jakub.kulik@oracle.com> writes:
Show 8 quoted lines
> Signed-off-by: Jakub Kulik <jakub.kulik@oracle.com>
> ---
>> Strictly speaking, POSIX compliant shells do not require such
>> quoting for pathnames that are used as redirection target.
>
> Indeed; when I run it with `bash --posix`, the test passes.
>
> Here is the patch with space between > and the filename removed.
Thanks.

I would fabricate a log message to say something about our CodingGuidelines ask you to quote variable references used for redirection targets or sources while queuing.

Show 26 quoted lines
>
>  t/t1017-cat-file-remote-object-info.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t1017-cat-file-remote-object-info.sh b/t/t1017-cat-file-remote-object-info.sh
> index e2919aa061..8a04cfdae8 100755
> --- a/t/t1017-cat-file-remote-object-info.sh
> +++ b/t/t1017-cat-file-remote-object-info.sh
> @@ -69,7 +69,7 @@ daemon_parent=$GIT_DAEMON_DOCUMENT_ROOT_PATH/parent
>  
>  test_expect_success 'create repo to be served by git-daemon' '
>  	git init "$daemon_parent" &&
> -	echo_without_newline "$hello_content" > $daemon_parent/hello &&
> +	echo_without_newline "$hello_content" >"$daemon_parent/hello" &&
>  	git -C "$daemon_parent" update-index --add hello &&
>  	git -C "$daemon_parent" config transfer.advertiseobjectinfo true &&
>  	git clone "$GIT_DAEMON_URL/parent" -n "$daemon_parent/daemon_client_empty"
> @@ -519,7 +519,7 @@ test_expect_success 'create repo to be served by http:// transport' '
>  	git init "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" &&
>  	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config http.receivepack true &&
>  	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config transfer.advertiseobjectinfo true &&
> -	echo_without_newline "$hello_content" > $HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello &&
> +	echo_without_newline "$hello_content" >"$HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello" &&
>  	git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" update-index --add hello &&
>  	git clone "$HTTPD_URL/smart/http_parent" -n "$HTTPD_DOCUMENT_ROOT_PATH/http_client_empty"
>  '

← back to recent threads