several unquoted shell variables causing test failures on Solaris
- From
- Jakub Kulik <jakub.kulik@oracle.com>
- Date
- Nov 12, 2026, 15:39 UTC
- Message-ID
- <SJ0PR10MB5785807828F81EAC8CA165E78A702@SJ0PR10MB5785.namprd10.prod.outlook.com>
Hi, when running tests on Solaris, I encountered several test failures in 't1017-cat-file-remote-object-info.sh' which look like this:
./test-lib.sh: line 1040: cd: /builds/components/git/build/amd64/t/trash directory.t1017-cat-file-remote-object-info/repo/parent/daemon_client_empty: No such file or directory not ok 12 - requesting only objectname echoes back
The reason seems to be several unquoted variables (needed because of the space in path), and with the following change, the test is fixed again:
--- git-2.56.0/t/t1017-cat-file-remote-object-info.sh +++ git-2.56.0/t/t1017-cat-file-remote-object-info.sh
@@ -69,7 +69,7 @@ daemon_parent=$GIT_DAEMON_DOCUMENT_ROOT_ test_expect_success 'create repo to be served by git-daemon' ' git init "$daemon_parent" && - echo_without_newline "$hello_content" > $daemon_parent/hello && + echo_without_newline "$hello_content" > "$daemon_parent/hello" && git -C "$daemon_parent" update-index --add hello && git -C "$daemon_parent" config transfer.advertiseobjectinfo true && git clone "$GIT_DAEMON_URL/parent" -n "$daemon_parent/daemon_client_empty" @@ -519,7 +519,7 @@ test_expect_success 'create repo to be s git init "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" && git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config http.receivepack true && git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" config transfer.advertiseobjectinfo true && - echo_without_newline "$hello_content" > $HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello && + echo_without_newline "$hello_content" > "$HTTPD_DOCUMENT_ROOT_PATH/http_parent/hello" && git -C "$HTTPD_DOCUMENT_ROOT_PATH/http_parent" update-index --add hello && git clone "$HTTPD_URL/smart/http_parent" -n "$HTTPD_DOCUMENT_ROOT_PATH/http_client_empty" ' Best Regards, Jakub