git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: several unquoted shell variables causing test failures on Solaris

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 12, 2026, 20:56 UTC
Message-ID
<xmqqik21hiqi.fsf@gitster.g>
In-Reply-To
<SJ0PR10MB5785807828F81EAC8CA165E78A702@SJ0PR10MB5785.namprd10.prod.outlook.com>
Jakub Kulik <jakub.kulik@oracle.com> writes:
Show 8 quoted lines
> Hi, when running tests on Solaris, I encountered several test failures in 't1017-cat-file-remote-object-info.sh' which look like this:
>
> ./test-lib.sh: line 1040: cd: /builds/components/git/build/amd64/t/trash directory.t1017-cat-file-remote-object-info/repo/parent/daemon_client_empty: No such file or directory
> not ok 12 - requesting only objectname echoes back
>
> The reason seems to be several unquoted variables (needed because
> of the space in path), and with the following change, the test is
> fixed again:

Strictly speaking, POSIX compliant shells do not require such quoting for pathnames that are used as redirection target.

But some shells are buggy, and our Documentation/CodingGuidelines do require them to be quoted. It also does require there is no space between redirection operator '>' and the filename, so the correct formulation would be:

> -     echo_without_newline "$hello_content" > $daemon_parent/hello &&
> +     echo_without_newline "$hello_content" > "$daemon_parent/hello" &&
	echo_without_newline "$hello_content" >"$daemon_parent/hello" &&
Care to submit an official fix with commit log message and sign off?
Thanks.
Previous: Jakub Kulik
Message 2 of 2 in “several unquoted shell variables causing test failures on Solaris”
  1. Jakub KulikNov 12, 2026
  2. Junio C HamanoNov 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.