git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 3, 2015, 20:18 UTC
Message-ID
<xmqqmvx3i7dg.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<A76D6BC6-E0AD-48F4-AE33-80BD0803BFA3@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 13 quoted lines
> On 03 Sep 2015, at 21:55, Luke Diamand <luke@diamand.org> wrote:
>
>> On 03/09/15 17:35, larsxschneider@gmail.com wrote:
>>> From: Lars Schneider <larsxschneider@gmail.com>
>>> 
>> 
>> I think this commit may need some explanation!
>
> The functions “gitConfig” and “gitConfigBool” are almost
> identical. Make “gitConfig” more generic by adding an optional type
> specifier. Use the type specifier “—bool” with “gitConfig” to
> implement “gitConfigBool. This prepares the implementation of other
> type specifiers such as “—int”.
OK.
> OK?

Not really ;-). The point of Luke's message is that all of the above belong to the log message, I think.

Previous: Lars SchneiderNext: Lars Schneider
Message 5 of 17 in “git-p4: add support for large file systems”
  1. git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 3, 2015
  2. 1/4 git-p4: add optional type specifier to gitConfig readerlarsxschneider@gmail.com, Sep 3, 2015
  3. Luke DiamandSep 3, 2015
  4. Lars SchneiderSep 3, 2015
  5. Junio C HamanoSep 3, 2015
  6. Lars SchneiderSep 3, 2015
  7. Junio C HamanoSep 3, 2015
  8. Lars SchneiderSep 4, 2015
  9. 2/4 git-p4: add gitConfigInt readerlarsxschneider@gmail.com, Sep 3, 2015
  10. Luke DiamandSep 3, 2015
  11. Lars SchneiderSep 3, 2015
  12. Luke DiamandSep 3, 2015
  13. 3/4 git-p4: return an empty list if a list config has no valueslarsxschneider@gmail.com, Sep 3, 2015
  14. 4/4 git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 3, 2015
  15. Luke DiamandSep 3, 2015
  16. Lars SchneiderSep 3, 2015
  17. Jeff KingSep 4, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.