Re: [PATCH v2 2/4] git-p4: add gitConfigInt reader
On 03/09/15 17:35, larsxschneider@gmail.com wrote:
> From: Lars Schneider <larsxschneider@gmail.com>
>
Show 21 quoted lines
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
> git-p4.py | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/git-p4.py b/git-p4.py
> index c139cab..ae1a4d3 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -623,6 +623,17 @@ def gitConfigBool(key):
> _gitConfig[key] = gitConfig(key, '--bool') == "true"
> return _gitConfig[key]
>
> +def gitConfigInt(key):
> + if not _gitConfig.has_key(key):
> + cmd = [ "git", "config", "--int", key ]
> + s = read_pipe(cmd, ignore_error=True)
> + v = s.strip()
> + try:
> + _gitConfig[key] = int(gitConfig(key, '--int'))
> + except Exception, e:
Could do with specifying the actual type of the exception here (ValueError).
Show 7 quoted lines
> + _gitConfig[key] = None
> + return _gitConfig[key]
> +
> def gitConfigList(key):
> if not _gitConfig.has_key(key):
> s = read_pipe(["git", "config", "--get-all", key], ignore_error=True)
>