git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/4] git-p4: add gitConfigInt reader

From
Luke Diamand <luke@diamand.org>
Date
Sep 3, 2015, 19:57 UTC
Message-ID
<55E8A647.90903@diamand.org>
In-Reply-To
<1441298148-63885-3-git-send-email-larsxschneider@gmail.com>
On 03/09/15 17:35, larsxschneider@gmail.com wrote:
> From: Lars Schneider <larsxschneider@gmail.com>
>
Explanation?
Show 21 quoted lines
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
>   git-p4.py | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/git-p4.py b/git-p4.py
> index c139cab..ae1a4d3 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -623,6 +623,17 @@ def gitConfigBool(key):
>           _gitConfig[key] = gitConfig(key, '--bool') == "true"
>       return _gitConfig[key]
>
> +def gitConfigInt(key):
> +    if not _gitConfig.has_key(key):
> +        cmd = [ "git", "config", "--int", key ]
> +        s = read_pipe(cmd, ignore_error=True)
> +        v = s.strip()
> +        try:
> +            _gitConfig[key] = int(gitConfig(key, '--int'))
> +        except Exception, e:
Could do with specifying the actual type of the exception here (ValueError).
Show 7 quoted lines
> +            _gitConfig[key] = None
> +    return _gitConfig[key]
> +
>   def gitConfigList(key):
>       if not _gitConfig.has_key(key):
>           s = read_pipe(["git", "config", "--get-all", key], ignore_error=True)
>
Previous: larsxschneider@gmail.comNext: Lars Schneider
Message 10 of 17 in “git-p4: add support for large file systems”
  1. git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 3, 2015
  2. 1/4 git-p4: add optional type specifier to gitConfig readerlarsxschneider@gmail.com, Sep 3, 2015
  3. Luke DiamandSep 3, 2015
  4. Lars SchneiderSep 3, 2015
  5. Junio C HamanoSep 3, 2015
  6. Lars SchneiderSep 3, 2015
  7. Junio C HamanoSep 3, 2015
  8. Lars SchneiderSep 4, 2015
  9. 2/4 git-p4: add gitConfigInt readerlarsxschneider@gmail.com, Sep 3, 2015
  10. Luke DiamandSep 3, 2015
  11. Lars SchneiderSep 3, 2015
  12. Luke DiamandSep 3, 2015
  13. 3/4 git-p4: return an empty list if a list config has no valueslarsxschneider@gmail.com, Sep 3, 2015
  14. 4/4 git-p4: add support for large file systemslarsxschneider@gmail.com, Sep 3, 2015
  15. Luke DiamandSep 3, 2015
  16. Lars SchneiderSep 3, 2015
  17. Jeff KingSep 4, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.