Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

From: Lars Schneider <larsxschneider@gmail.com>
Date: Sep 3, 2015, 20:53 UTC
Message-ID: <6FAAE139-9010-4C68-AA97-2739E9A09564@gmail.com>
In-Reply-To: <xmqqmvx3i7dg.fsf@gitster.mtv.corp.google.com>

On 03 Sep 2015, at 22:18, Junio C Hamano <gitster@pobox.com> wrote:

Show 22 quoted lines

> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>> On 03 Sep 2015, at 21:55, Luke Diamand <luke@diamand.org> wrote:
>> 
>>> On 03/09/15 17:35, larsxschneider@gmail.com wrote:
>>>> From: Lars Schneider <larsxschneider@gmail.com>
>>>> 
>>> 
>>> I think this commit may need some explanation!
>> 
>> The functions “gitConfig” and “gitConfigBool” are almost
>> identical. Make “gitConfig” more generic by adding an optional type
>> specifier. Use the type specifier “—bool” with “gitConfig” to
>> implement “gitConfigBool. This prepares the implementation of other
>> type specifiers such as “—int”.
> 
> OK.
> 
>> OK?
> 
> Not really ;-).  The point of Luke's message is that all of the
> above belong to the log message, I think.

Right, it is my intention to add this as commit message. I just wanted to check upfront if the message is what he expects.

That leads me to a general question: In case I agree with a reviewer. What is the more appropriate action? A response like the one above or a new role that includes the change right away? I don’t want to spam the list with lots of tiny changes…

Thanks!