From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 03 Sep 2015 20:18:51 GMT
Subject: Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader
Message-ID: <xmqqmvx3i7dg.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <A76D6BC6-E0AD-48F4-AE33-80BD0803BFA3@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

> On 03 Sep 2015, at 21:55, Luke Diamand <luke@diamand.org> wrote:
>
>> On 03/09/15 17:35, larsxschneider@gmail.com wrote:
>>> From: Lars Schneider <larsxschneider@gmail.com>
>>> 
>> 
>> I think this commit may need some explanation!
>
> The functions “gitConfig” and “gitConfigBool” are almost
> identical. Make “gitConfig” more generic by adding an optional type
> specifier. Use the type specifier “—bool” with “gitConfig” to
> implement “gitConfigBool. This prepares the implementation of other
> type specifiers such as “—int”.

OK.

> OK?

Not really ;-).  The point of Luke's message is that all of the
above belong to the log message, I think.