Re: [PATCH v2 2/2] mailinfo: unescape quoted-pair in header fields

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 19, 2016, 22:04 UTC
Message-ID: <xmqqmvj3czsf.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqvaxrd1ml.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 18 quoted lines

> Kevin Daudt <me@ikke.info> writes:
>
>> +static void unquote_quoted_string(struct strbuf *line)
>> +{
>> +	const char *in = strbuf_detach(line, NULL);
>> +	int c, take_next_literally = 0;
>> +	int found_error = 0;
> ...
>> +	}
>> +}
>
> The additional comment makes it very clear what is going on.
>
> Is it an event unusual enough that is worth warning() about if we
> have either take_next_literally or escape_context set to non-NUL
> upon leaving the loop, I wonder?
>
> Will queue.  Thanks.

It turns out that found_error is not used anywhere and tripped the -Werror=unused-variable check. I've removed that line while queuing.

Thanks.