Re: [PATCH v2 2/2] mailinfo: unescape quoted-pair in header fields

From: Kevin Daudt <me@ikke.info>
Date: Sep 25, 2016, 20:17 UTC
Message-ID: <20160925201713.GA6937@ikke.info>
In-Reply-To: <20160923041540.5fvl6ytp2tvcflsk@sigill.intra.peff.net>

On Fri, Sep 23, 2016 at 12:15:41AM -0400, Jeff King wrote:

Show 38 quoted lines

> On Thu, Sep 22, 2016 at 03:17:23PM -0700, Junio C Hamano wrote:
> 
> > Jeff King <peff@peff.net> writes:
> > 
> > > On Mon, Sep 19, 2016 at 08:54:40PM +0200, Kevin Daudt wrote:
> > >
> > >> + ...
> > >> +	while ((c = *in++) != 0) {
> > >> +		if (take_next_literally) {
> > >> +			take_next_literally = 0;
> > >> +		} else {
> > >> [...]
> > >> +		}
> > >> +
> > >> +		strbuf_addch(line, c);
> > >> +	}
> > >> +}
> > >
> > > It needs to `free(in)` at the end of the function.
> > 
> > Ehh, in has been incremented and is pointing at the terminating NUL
> > there, so it would be more like
> > 
> > 	char *to_free, *in;
> > 
> >         to_free = strbuf_detach(line, NULL);
> >         in = to_free;
> > 	...
> >         while ((c = *in++)) {
> >         	...
> > 	}
> >         free(to_free);
> > 
> > I would think ;-).
> 
> Oops, yes. It is beginning to make the "strbuf_swap()" look less
> convoluted. :)
>

I've switched to strbuf_swap now, much better. I've implemented recursive parsing without looking at what you provided, just to see what I'd came up with. Though I've not implemented a recursive descent parser, but it might suffice.

I'm sending the patches now.