Re: [PATCH v3 2/2] mailinfo: unescape quoted-pair in header fields

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 26, 2016, 22:23 UTC
Message-ID: <xmqq7f9ypag4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160926194455.GB19089@ikke.info>

Kevin Daudt <me@ikke.info> writes:

Show 11 quoted lines

> On Mon, Sep 26, 2016 at 12:26:13PM -0700, Junio C Hamano wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> > Don't these also need to be downcased if you prefer $data over
>> > $DATA, though?
>> 
>> For now, I'll queue a SQUASH??? that reverts s/DATA/data/ you did to
>> 1/2 between your 1/2 and 2/2.
>
> Ugh, thanks. I'd replaced it in the first patch, but forgot it in the
> second.

Heh, I already guessed that much that these were sent without even be in the tree, after editing only the patch files. Don't do that ;-)

I am not sure I agree that $data is better over $DATA, though. Unlike the lowercase $mail and others used in the script that are clearly "variables", this thing is used as a constant during the lifetime of the test script.