Re: [PATCH v2 2/2] mailinfo: unescape quoted-pair in header fields
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 22, 2016, 22:17 UTC
- Message-ID
- <xmqq60pn37gs.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160921110934.f6eu2dz6i2mlpa45@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 15 quoted lines
> On Mon, Sep 19, 2016 at 08:54:40PM +0200, Kevin Daudt wrote:
>
>> + ...
>> + while ((c = *in++) != 0) {
>> + if (take_next_literally) {
>> + take_next_literally = 0;
>> + } else {
>> [...]
>> + }
>> +
>> + strbuf_addch(line, c);
>> + }
>> +}
>
> It needs to `free(in)` at the end of the function.Ehh, in has been incremented and is pointing at the terminating NUL there, so it would be more like
char *to_free, *in;
to_free = strbuf_detach(line, NULL);
in = to_free;
...
while ((c = *in++)) {
...
}
free(to_free);I would think ;-).