Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2017, 22:18 UTC
Message-ID: <xmqqmv6r1c26.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170822213501.5928-1-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 9 quoted lines

> The svn specific declaration of repo_init was not used since 723b7a2789
> (vcs-svn: eliminate repo_tree structure, 2010-12-10).
>
> This was noticed when including repository.h via cache.h as that has the
> same function with a different signature.
>
> Helped-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---

It looks to me that this is a reduced duplicate of what brian posted yesterday. The first two patches in the 6-patch series that you commented on, I think, covers what this change wants to achieve and probably a lot more. I've merged those two already to 'next' and was about to push the result out.

Thanks.

Show 15 quoted lines

>  vcs-svn/repo_tree.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/vcs-svn/repo_tree.h b/vcs-svn/repo_tree.h
> index 889c6a3c95..8592beb59b 100644
> --- a/vcs-svn/repo_tree.h
> +++ b/vcs-svn/repo_tree.h
> @@ -17,7 +17,6 @@ void repo_commit(uint32_t revision, const char *author,
>  		const struct strbuf *log, const char *uuid, const char *url,
>  		long unsigned timestamp);
>  void repo_diff(uint32_t r1, uint32_t r2);
> -void repo_init(void);
>  void repo_reset(void);
>  
>  #endif