git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Aug 22, 2017, 23:45 UTC
Message-ID
<20170822234553.GC13924@aiede.mtv.corp.google.com>
In-Reply-To
<xmqqmv6r1c26.fsf@gitster.mtv.corp.google.com>
Junio C Hamano wrote:
> Stefan Beller <sbeller@google.com> writes:
Show 15 quoted lines
>> The svn specific declaration of repo_init was not used since 723b7a2789
>> (vcs-svn: eliminate repo_tree structure, 2010-12-10).
>>
>> This was noticed when including repository.h via cache.h as that has the
>> same function with a different signature.
>>
>> Helped-by: Jonathan Nieder <jrnieder@gmail.com>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>
> It looks to me that this is a reduced duplicate of what brian posted
> yesterday.  The first two patches in the 6-patch series that you
> commented on, I think, covers what this change wants to achieve and
> probably a lot more.  I've merged those two already to 'next' and
> was about to push the result out.

I just sent https://public-inbox.org/git/20170822233732.GX13924@aiede.mtv.corp.google.com/ to fix this more thoroughly. I can rebase on top of bc/vcs-svn-cleanup if that is helpful --- just say the word.

Thanks, Jonathan

Previous: Jonathan NiederNext: Junio C Hamano
Message 5 of 6 in “vcs-svn/repo_tree.h: remove repo_init declaration”
  1. vcs-svn/repo_tree.h: remove repo_init declarationStefan Beller, Aug 22, 2017
  2. Junio C HamanoAug 22, 2017
  3. Stefan BellerAug 22, 2017
  4. Jonathan NiederAug 22, 2017
  5. Jonathan NiederAug 22, 2017
  6. Junio C HamanoAug 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.