Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration

From: Stefan Beller <sbeller@google.com>
Date: Aug 22, 2017, 22:24 UTC
Message-ID: <CAGZ79kbMc+kVsc2-fBfOHVZvvABWnDpQfs-hqLCxb2FTTr8YCQ@mail.gmail.com>
In-Reply-To: <xmqqmv6r1c26.fsf@gitster.mtv.corp.google.com>

On Tue, Aug 22, 2017 at 3:18 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>
>> The svn specific declaration of repo_init was not used since 723b7a2789
>> (vcs-svn: eliminate repo_tree structure, 2010-12-10).
>>
>> This was noticed when including repository.h via cache.h as that has the
>> same function with a different signature.
>>
>> Helped-by: Jonathan Nieder <jrnieder@gmail.com>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>
> It looks to me that this is a reduced duplicate of what brian posted
> yesterday.  The first two patches in the 6-patch series that you
> commented on, I think, covers what this change wants to achieve and
> probably a lot more.  I've merged those two already to 'next' and
> was about to push the result out.
>
> Thanks.
>

Ok, thanks. I did not remember reviewing those. (I just wanted to fix my odd compile error here, and currently I build a series on top of jt/packmigrate so I shot off a quick one liner)

Sorry for the noise.