Re: [PATCH] vcs-svn/repo_tree.h: remove repo_init declaration

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 22, 2017, 22:54 UTC
Message-ID: <20170822225405.GV13924@aiede.mtv.corp.google.com>
In-Reply-To: <xmqqmv6r1c26.fsf@gitster.mtv.corp.google.com>

Junio C Hamano wrote:

> Stefan Beller <sbeller@google.com> writes:

Show 14 quoted lines

>> The svn specific declaration of repo_init was not used since 723b7a2789
>> (vcs-svn: eliminate repo_tree structure, 2010-12-10).
>>
>> This was noticed when including repository.h via cache.h as that has the
>> same function with a different signature.
>>
>> Helped-by: Jonathan Nieder <jrnieder@gmail.com>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>
> It looks to me that this is a reduced duplicate of what brian posted
> yesterday.  The first two patches in the 6-patch series that you
> commented on, I think, covers what this change wants to achieve and
> probably a lot more.  I've merged those two already to 'next' and
> was about to push the result out.

Thanks for the pointer. I believe you're referring to https://public-inbox.org/git/20170821000022.26729-2-sandals@crustytoothpaste.net/.

From Stefan's verbal report I was about to send a patch just like Brian's plus some more patches on top to get rid of the rest of repo_tree.h. I can build on top of Brian's patch if that's more convenient.

Regards, Jonathan