Re: [PATCH 7/7] t6120: fix typo in test name

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2017, 01:36 UTC
Message-ID: <xmqqmv45sbpq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqh8ueyet8.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>>  t/t6120-describe.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Good.  I am guessing that you are sending this as the last/optional
> one because this was found _after_ you worked on other parts of the
> series, but I think it is easier to reason about if this were marked
> as a preliminary clean-up and moved to the front of the series.
>
> Thanks.

Having said that, if you already have v2 that keeps it at the end, that is fine.

It's just leaving such an "By the way I found this unrelated one and fixed it while at it" at the end when submitting will give an impression that the series is not as well proof-read as it could be, because a good proof-reader would notice something out-of-place like this fairly quickly and would move it to the front or even in a separate preliminary clean-up series.