Re: [PATCH 2/3] revision.h: introduce blob/tree walking in order of the commits

From: Stefan Beller <sbeller@google.com>
Date: Oct 29, 2017, 03:22 UTC
Message-ID: <CAGZ79kaVqSzzPebHN4=extkAPpyi=VagmjFU8mh_A_tYoJgU8g@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.21.1.1710281917260.6482@virtualbox>

On Sat, Oct 28, 2017 at 10:20 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 9 quoted lines

> Hi Stefan,
>
> On Fri, 27 Oct 2017, Stefan Beller wrote:
>
>> This will be useful shortly.
>
> Something tells me that I will hate you in the future when I read this
> commit message and lack the context (e.g. when blaming, where I cannot see
> the child commits let alone the comment in the Merge commit).

Thanks for calling me out.

(Not making excuses, but...) I remembered some other senior members having such commit messages, so I felt like I had to step up my game.

https://public-inbox.org/git/70fbcd573f5c8a78a19a08ffc255437c36e7f49d.1495014840.git.mhagger@alum.mit.edu/

Show 7 quoted lines

>
> How about:
>
>         The functionality to list tree objects in the order they were seen
>         while traversing the commits will be used in the next commit,
>         where we teach `git describe` to describe not only commits, but
>         trees and blobs, too.

Sounds good. If only we had git-when-merged[1] as some easy upstream function, then the original commit message would provoke less hate as future us would have an easier time finding the next commit.

[1] https://github.com/mhagger/git-when-merged

When writing the patch I wondered if this could be useful for other use cases as well, i.e. do we want to have a command line argument to trigger this behavior?

Thanks, Stefan