Re: [PATCH 7/7] t6120: fix typo in test name
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 1, 2017, 01:21 UTC
- Message-ID
- <xmqqh8ueyet8.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20171031003351.22341-8-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
> Signed-off-by: Stefan Beller <sbeller@google.com> > --- > t/t6120-describe.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Good. I am guessing that you are sending this as the last/optional one because this was found _after_ you worked on other parts of the series, but I think it is easier to reason about if this were marked as a preliminary clean-up and moved to the front of the series.
Thanks.
Show 14 quoted lines
> > diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh > index 3be01316e8..fd329f173a 100755 > --- a/t/t6120-describe.sh > +++ b/t/t6120-describe.sh > @@ -304,7 +304,7 @@ test_expect_success 'describe chokes on severely broken submodules' ' > mv .git/modules/sub1/ .git/modules/sub_moved && > test_must_fail git describe --dirty > ' > -test_expect_success 'describe ignoring a borken submodule' ' > +test_expect_success 'describe ignoring a broken submodule' ' > git describe --broken >out && > test_when_finished "mv .git/modules/sub_moved .git/modules/sub1" && > grep broken out