Re: [PATCHv2 2/7] revision.h: introduce blob/tree walking in order of the commits

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 1, 2017, 22:39 UTC
Message-ID: <alpine.DEB.2.21.1.1711012337270.6482@virtualbox>
In-Reply-To: <CAGZ79kbYshVjUh2XhbLHtYmnRuFaCmuWZJZd7HifKAqJbNBPfw@mail.gmail.com>

Hi Stefan,

On Wed, 1 Nov 2017, Stefan Beller wrote:

Show 10 quoted lines

> We do not care about the internal state, aborting early, we rather
> care only if the whole loop body was executed. Running the test
> 
>     test_expect_success 'witty title' '
>         for a in 1 2 3; do echo $a && false; done && echo done
>     '
> 
> not ok 1 - witty title
> 
> That is all we want to care about here?

We care about the loop body being executed successfully *each time*. A better counter example:

$ for a in 1 2 3; do echo $a && test 2 != $a || false; done && echo done 1 2 3 done

(even if the second of three runs failed)

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.