Re: [GSoC][PATCH v5] test: avoid pipes in git related commands for test

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 30, 2018, 22:08 UTC
Message-ID: <xmqqmuyp1aj8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAPig+cSykgDMO-CMc0O5g5ke7D3VSKoaQdNLQDHfu8oTWTDS6w@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 10 quoted lines

> On Tue, Mar 27, 2018 at 1:31 PM, Pratik Karki <predatoramigo@gmail.com> wrote:
>> Avoid using pipes downstream of Git commands since the exit codes
>> of commands upstream of pipes get swallowed, thus potentially
>> hiding failure of those commands. Instead, capture Git command
>> output to a file and apply the downstream command(s) to that file.
>>
>>
>> Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
>
> Unnecessary double blank line above sign-off.

"git am" would automatically trigger stripspace, which would eat the extra blank line from that two-blank-line block.

> Aside from that minor hiccup (which Junio fixed when queuing), this
> iteration addresses all my review comments[1] from the previous round
> and does not seem to introduce any new issues.

Thanks for a review.