git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH v5] test: avoid pipes in git related commands for test

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 30, 2018, 21:45 UTC
Message-ID
<CAPig+cSykgDMO-CMc0O5g5ke7D3VSKoaQdNLQDHfu8oTWTDS6w@mail.gmail.com>
In-Reply-To
<20180327173137.5970-1-predatoramigo@gmail.com>
On Tue, Mar 27, 2018 at 1:31 PM, Pratik Karki <predatoramigo@gmail.com> wrote:
Show 7 quoted lines
> Avoid using pipes downstream of Git commands since the exit codes
> of commands upstream of pipes get swallowed, thus potentially
> hiding failure of those commands. Instead, capture Git command
> output to a file and apply the downstream command(s) to that file.
>
>
> Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
Unnecessary double blank line above sign-off.

Aside from that minor hiccup (which Junio fixed when queuing), this iteration addresses all my review comments[1] from the previous round and does not seem to introduce any new issues.

Thanks.
[1]: https://public-inbox.org/git/CAPig+cS3GjYo+5C_W6WqzK3RP=W+918E6Cz=FSvHky6EWCEZPA@mail.gmail.com/
Previous: Pratik KarkiNext: Junio C Hamano
Message 15 of 16 in “test: avoid pipes in git related commands for test suite”
  1. Pratik KarkiMar 13, 2018
  2. Eric SunshineMar 14, 2018
  3. Ævar Arnfjörð BjarmasonMar 14, 2018
  4. Eric SunshineMar 14, 2018
  5. Junio C HamanoMar 15, 2018
  6. [GSoC][PATCH] test: avoid pipes in git related commands for test suitePratik Karki, Mar 19, 2018
  7. Eric SunshineMar 21, 2018
  8. [GSoC][PATCH v3] test: avoid pipes in git related commands for testPratik Karki, Mar 21, 2018
  9. Junio C HamanoMar 21, 2018
  10. Eric SunshineMar 21, 2018
  11. Eric SunshineMar 21, 2018
  12. [GSoC][PATCH v4] test: avoid pipes in git related commands for testPratik Karki, Mar 23, 2018
  13. Eric SunshineMar 25, 2018
  14. [GSoC][PATCH v5] test: avoid pipes in git related commands for testPratik Karki, Mar 27, 2018
  15. Eric SunshineMar 30, 2018
  16. Junio C HamanoMar 30, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.