Re: [GSoC][PATCH v3] test: avoid pipes in git related commands for test

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 21, 2018, 18:58 UTC
Message-ID: <CAPig+cRnO6e5B=mYAfkt7bdgit2uOJk1a+CAahQ2+uRRbPAObQ@mail.gmail.com>
In-Reply-To: <xmqqo9jhpadh.fsf@gitster-ct.c.googlers.com>

On Wed, Mar 21, 2018 at 2:11 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> Pratik Karki <predatoramigo@gmail.com> writes:
>>  Avoid using pipes downstream of Git commands since the exit
>>  codes of commands upstream of pipes get swallowed, thus potentially hiding
>>  failure of those commands. Instead, capture Git command output to a file and
>>  apply the downstream command(s) to that file.
>
> Please do not indent the body of the log message by one space.

One other issue I forgot to mention is that the commit message in v3 started getting too wide again[1]; it was fine in v2. Pratik, try to keep the commit message wrapped to about 70-72 characters or so.

[1]: https://public-inbox.org/git/CAPig+cRPzyw525ODC4=-E7w=zbpbhVN2eqxSYDSLij5wfW8S_A@mail.gmail.com/