Re: [PATCH] completion: reduce overhead of clearing cached --options

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 16, 2018, 22:43 UTC
Message-ID: <xmqqmuy2wz4j.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CANQwDwf8sBFuKBXG6Yt5CH9+E2doqB6rB-_oQ4U7vjTOYBfu_g@mail.gmail.com>

Jakub Narębski <jnareb@gmail.com> writes:

Show 11 quoted lines

> On 16 April 2018 at 15:15, SZEDER Gábor <szeder.dev@gmail.com> wrote:
>> No.  'sed' would only need need help when its input comes from a buggy
>> 'set' builtin of a particular version of Bash from a particular vendor.
>>
>> As far as I can test this in Travis CI's OSX builds, ZSH doesn't seem to
>> be affected, neither the version Apple ships by default nor the version
>> installed via homebrew.
>
> That's nice - this means that the patch fixes all of the issue.
> The above information should be, in my opinion, included
> in the commit message, though.

Yeah, I tend to agree.  Thanks.