Re: [PATCH] completion: reduce overhead of clearing cached --options
- From
Matthew Coleman <matt@1eanda.com>
- Date
- Apr 16, 2018, 20:35 UTC
- Message-ID
- <6A862FDA-1EBA-47BB-8C99-AB09DA91955D@1eanda.com>
- In-Reply-To
- <CA+P7+xqVdhJ3PrGjQWcofHJV3E1UYWVHEXVt5yaV3Ycv1YvkTg@mail.gmail.com>
Disclaimer: I'm not a zsh user, so please correct anything I might have gotten wrong.
I created a .zshrc with the following contents: autoload -Uz compinit compinit source /usr/local/lib/python3.6/site-packages/powerline/bindings/zsh/powerline.zsh
zsh doesn't have broken Unicode output in its `set` builtin, so it was not affected by the original issue. Applying the patch does not cause any change in behavior.
Since the commit only changes a file with "bash" in its name, but the conditional references zsh variables, I think it's worth mentioning something about it in the commit message.
I think the bash side of things is all set for this commit, but can a similar improvement be made (using a builtin instead of parsing set|sed) for zsh? Again, I'm not a zsh user, so some input from someone who's written zsh completion rules would be very helpful. Can any of the builtins mentioned in this zsh documentation be used instead of set|sed? http://zsh.sourceforge.net/Doc/Release/Zsh-Modules.html#The-zsh_002fcomputil-Module
Show 28 quoted lines
> On Apr 16, 2018, at 2:23 PM, Jacob Keller <jacob.keller@gmail.com> wrote: > > On Sat, Apr 14, 2018 at 6:27 AM, Jakub Narebski <jnareb@gmail.com> wrote: >> SZEDER Gábor <szeder.dev@gmail.com> writes: >>> On Fri, Apr 13, 2018 at 11:44 PM, Jakub Narebski <jnareb@gmail.com> wrote: >>>> SZEDER Gábor <szeder.dev@gmail.com> writes: >>>>> >>>>> In Bash we can do better: run the 'compgen -v __gitcomp_builtin_' >>>>> builtin command, which lists the same variables, but without a >>>>> pipeline and 'sed' it can do so with lower overhead. >>>> >>>> What about ZSH? >>> >>> Nothing, ZSH is unaffected by this patch. >> >> All right, so for ZSH we would need LC_ALL=C trick, or come with some >> equivalent of 'compgen -v __gitcomp_builtin_' for this shell. >> >> Good patch, though it does not solve whole of the problem. >> >> Best, >> -- >> Jakub Narębski > > Is ZSH actually affected by the broken set behavior, though? > > Thanks, > Jake