Re: [PATCH] completion: reduce overhead of clearing cached --options

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Apr 16, 2018, 13:15 UTC
Message-ID: <CAM0VKjm=jyetT9ucNbOYxQ19BGYr8nWzAi+WUnsHPuRTrSG9SA@mail.gmail.com>
In-Reply-To: <xmqq7ep7ybw2.fsf@gitster-ct.c.googlers.com>

On Mon, Apr 16, 2018 at 7:10 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> SZEDER Gábor <szeder.dev@gmail.com> writes:
>
>> On Fri, Apr 13, 2018 at 11:44 PM, Jakub Narebski <jnareb@gmail.com> wrote:
>>> SZEDER Gábor <szeder.dev@gmail.com> writes:
>>>> In Bash we can do better: run the 'compgen -v __gitcomp_builtin_'
>>>> builtin command, which lists the same variables, but without a
>>>> pipeline and 'sed' it can do so with lower overhead.
>>>
>>> What about ZSH?
>>
>> Nothing, ZSH is unaffected by this patch.
>
> OK, do we want to follow it up with [PATCH 2/1] to add the LC_ALL=C
> thing to the ZSH side to help that "sed", then?

No. 'sed' would only need need help when its input comes from a buggy 'set' builtin of a particular version of Bash from a particular vendor.

As far as I can test this in Travis CI's OSX builds, ZSH doesn't seem to be affected, neither the version Apple ships by default nor the version installed via homebrew.