Re: [PATCH] completion: reduce overhead of clearing cached --options

From: Jakub Narebski <jnareb@gmail.com>
Date: Apr 14, 2018, 13:27 UTC
Message-ID: <86sh7xlxyp.fsf@gmail.com>
In-Reply-To: <CAM0VKjkKE695mMPgmfgzWJPaJThdLDSESV9KmupQX_bm-6MW-w@mail.gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 10 quoted lines

> On Fri, Apr 13, 2018 at 11:44 PM, Jakub Narebski <jnareb@gmail.com> wrote:
>> SZEDER Gábor <szeder.dev@gmail.com> writes:
>>>
>>> In Bash we can do better: run the 'compgen -v __gitcomp_builtin_'
>>> builtin command, which lists the same variables, but without a
>>> pipeline and 'sed' it can do so with lower overhead.
>>
>> What about ZSH?
>
> Nothing, ZSH is unaffected by this patch.

All right, so for ZSH we would need LC_ALL=C trick, or come with some equivalent of 'compgen -v __gitcomp_builtin_' for this shell.

Good patch, though it does not solve whole of the problem.

Best,

-- 
Jakub Narębski